Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

done compatible with Sendable #1159

Merged
merged 2 commits into from
Dec 12, 2024
Merged

done compatible with Sendable #1159

merged 2 commits into from
Dec 12, 2024

Conversation

soranoba
Copy link
Contributor

resolve #1158

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?: Yes
  • Does this have documentation?: No needed.
  • Does this break the public API (Requires major version bump)?: No needed.
  • Is this a new feature (Requires minor version bump)?: Yes (may be)

soranoba
soranoba commented Sep 24, 2024
View reviewed changes
Tests/NimbleTests/AsyncAwaitTest.swift
await waitUntil { done in
let queue = OperationQueue()
let op = BlockOperation {}
op.completionBlock = done
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On Swift5:
    • Before
      • Warning: Assigning non-sendable parameter 'done' to a @Sendable closure
    • After
      • No-Warning

@younata younata merged commit fd4a97e into Quick:main Dec 12, 2024
6 of 16 checks passed
@younata
Copy link
Member

younata commented Dec 12, 2024

Thanks for doing this! Sorry it took so long for me to take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younata younata younata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why not make waitUntil's done compatible with Sendable?
2 participants
@soranoba @younata